[BUGFIX] Use routeName instead of fullRouteName in QP meta #14487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trentmwillis
force-pushed
the
qp-engines
branch
from
54e626e to
a63e5fe
Compare
Member
|
Awesome, thank you @trentmwillis! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accidentally broke the Controller lookup for QPs in Engines in the last round of changes. I mistakenly thought we should use
fullRouteNameinside of_qpto avoid potential collisions in the BucketCache, but that value is also used to look up the Route's Controller so it shouldn't be fully resolved.Additionally, the BucketCache seems to be unique per engine-instance, so collisions shouldn't be an issue.
Edit: Added a bunch of tests in the ember-engines repo to verify everything works as expected with this change. See ember-engines/ember-engines#227 for more info.