Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX beta] Update route-recognizer to v0.2.8. #14546

Merged
merged 1 commit into from
Oct 30, 2016

Conversation

nathanhammond
Copy link
Member

@nathanhammond nathanhammond commented Oct 28, 2016

Changes in this version account for edge cases which result in undefined behavior in route-recognizer:

Should be backward compatible but making sure that we get most of a canary cycle with eyes on this.

@nathanhammond nathanhammond force-pushed the update-rr branch 4 times, most recently from ce47bf4 to 0e5ae5b Compare October 29, 2016 00:15
@nathanhammond
Copy link
Member Author

nathanhammond commented Oct 29, 2016

There is one actual Ember bug: we appear to recalculate link-to's href during teardown if a bound param into the link-to component is torn down prior to the link-to being torn down. The upstream changes throw an error if you attempt to generate a URL without all of the specified params, so in combination it now throws an error.

I haven't finished tracing that issue. As this is actually a separate and different issue it will come separate from this PR. Depending upon how complicated and invasive that fix is will determine if I tag it as a [BUGFIX release|beta].

@nathanhammond
Copy link
Member Author

After building the test the {{link-to}} helper does not throw an error if its route has exited as an application I have discovered that the test itself is invalid. I've modified the test to do what it was originally intending to accomplish (confirm that we don't tear down controllers) and made the test pass.

I could not produce the failure of my original hypothesis (which is why I was delayed in addressing this).

@nathanhammond nathanhammond force-pushed the update-rr branch 2 times, most recently from 6d4dcbd to 885200b Compare October 30, 2016 17:24
@nathanhammond nathanhammond changed the title [BUGFIX] Update route-recognizer to v0.2.8. [BUGFIX beta] Update route-recognizer to v0.2.8. Oct 30, 2016
@rwjblue rwjblue merged commit 86f0a30 into emberjs:master Oct 30, 2016
@rwjblue
Copy link
Member

rwjblue commented Oct 30, 2016

Thanks @nathanhammond!

@nathanhammond nathanhammond deleted the update-rr branch October 30, 2016 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants