Update "handlebars" to v4.0.6 #14853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chadhietala
reviewed
Feb 17, 2017
| code: code.replace(/export var isFunction/, 'export { isFunction }'), | ||
| code: code | ||
| .replace('exports.__esModule = true;', '') | ||
| .replace('exports[\'default\'] = handlebars;', 'export default handlebars;'), |
There was a problem hiding this comment.
I'm wondering if we can just open up a PR on the Handlebars repo to distribute the ES6 source, so we can just use it wholesale instead of re-writing it.
There was a problem hiding this comment.
Did this get updated to use the ES6 distributed files?
There was a problem hiding this comment.
Not yet, because there is no release yet that distributes it as ES6. It's only on master so far.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to glimmerjs/glimmer-vm#397
/cc @rwjblue