Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid a couple of redundant property loads. #15000

Merged
merged 1 commit into from
Mar 11, 2017
Merged

Avoid a couple of redundant property loads. #15000

merged 1 commit into from
Mar 11, 2017

Conversation

bmeurer
Copy link
Contributor

@bmeurer bmeurer commented Mar 11, 2017

Due to the generally high level of polymorphism, these redundant property loads cannot be optimized appropriately by the JavaScript engines. So better just avoid them in the first place.

@rwjblue
Copy link
Member

rwjblue commented Mar 11, 2017

Awesome, thank you!

scalvert
scalvert reviewed Mar 11, 2017
View reviewed changes
Copy link
Contributor

@scalvert scalvert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rwjblue rwjblue merged commit 5ff9fd5 into emberjs:master Mar 11, 2017
@bmeurer
Copy link
Contributor Author

bmeurer commented Mar 11, 2017

Nice. Thanks!

@bmeurer bmeurer deleted the AvoidRedundantPropertyLoads branch March 11, 2017 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scalvert scalvert scalvert left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bmeurer @rwjblue @scalvert