Fix access to service:-document in ember-engines #15129
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run into some problems trying to get some code to render server-side. I think the problem was related to
ember-wormhole
, although the addon currently doesn't have a good way to work in server-side at all, but it still required a reference to the document service to be able to initialize.Although this can be fixed in ember-wormhole, I think it's good idea to allow components in engines to get access to the document if they need to and cover future problems.
Not sure whether enhancing the application instance test is enough, but not sure where to put a test, which says components in
ember-engines
must have access to theservice:-document
in applications, which usesember-cli-fastboot
.