Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolves #15154 #15161

Merged
merged 1 commit into from
Apr 25, 2017
Merged

resolves #15154 #15161

merged 1 commit into from
Apr 25, 2017

Conversation

mk-conn
Copy link

@mk-conn mk-conn commented Apr 24, 2017

Fixes #15154.
Implemented small fix as suggested by @rwjblue.

@locks
Copy link
Contributor

locks commented Apr 24, 2017

Hi @mk-conn, could you change the commit message to be a bit more descriptive? Something like "[BUGFIX release] Fixes #15154. Replaces .includes with .indexOf".

@stefanpenner
Copy link
Member

stefanpenner commented Apr 24, 2017

Hi @mk-conn, could you change the commit message to be a bit more descriptive? Something like "[BUGFIX release] Fixes #15154. Replaces .includes with .indexOf".

This would merely duplicate the diff in english in the commit message. The commit message should explain why not what. The diff tell us what already.

Usage of `Array#includes` is not supported by IE11.
@locks locks merged commit 0f1d5f5 into emberjs:master Apr 25, 2017
@locks
Copy link
Contributor

locks commented Apr 25, 2017

@mk-conn sorry for tweaking your commit like that, usually we'd wait for your action but 2.13 is coming out soon and I wanted to be sure this would get in!

@mk-conn
Copy link
Author

mk-conn commented Apr 25, 2017

No prob @locks - I was laying in bed sick yesterday and did not really want to hang at the computer so I could not respond...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Internet Explorer (v11): Object doesn't support property or method 'includes'
3 participants