[BUGFIX] controller replaceRoute considers engine's mount point
#15176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spencer516
force-pushed
the
controller-engine-replace-route
branch
from
3a98489 to
6df05e9
Compare
|
This fix looks good, sorry for taking so long to review! Can you rebase so we can get a new CI run kicked off to make sure it all still passes? |
spencer516
force-pushed
the
controller-engine-replace-route
branch
from
6df05e9 to
b18873a
Compare
|
@rwjblue — rebased and it's passed! |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems like there was a small error and a missing test when using
replaceRoutefrom a controller that is inside of an engine. This change mirrors the same for `transitionToRoute.