Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX release] Ensure nested custom elements render properly. #15247

Merged
merged 1 commit into from
May 17, 2017

Conversation

rwjblue
Copy link
Member

@rwjblue rwjblue commented May 17, 2017

A bug was introduced with the Glimmer update that was included in Ember 2.13 that caused an error to be thrown when using nested custom elements like:

<foo-bar>
  <baz-qux></baz-qux>
</foo-bar>

The fix was done upstream in glimmerjs/glimmer-vm#488.

Fixes #15221

A bug was introduced with the Glimmer update that was included in
Ember 2.13 that caused an error to be thrown when using nested
custom elements like:

```hbs
<foo-bar>
  <baz-qux></baz-qux>
</foo-bar>
```

The fix was done upstream in glimmerjs/glimmer-vm#488.
@rwjblue rwjblue merged commit c01b64b into emberjs:master May 17, 2017
@rwjblue rwjblue deleted the custom-elements branch May 17, 2017 19:44
@homu homu mentioned this pull request May 17, 2017
29 tasks
@bjornharrtell
Copy link

Still having problems in what appears related to this. See adopted-ember-addons/ember-paper#709 and glimmerjs/glimmer-vm#453.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2.13 custom elements regression
2 participants