[BUGFIX beta] Make better errors for meta updates after object destruction. #15347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ction. Prior to this change the errors being thrown by `Meta` were extremely hard to track down since no "real" information was given. After this change, all errors include the `object.toString` and property name in question (if applicable).
|
/cc @runspired |
nag5000
reviewed
Jul 17, 2017
| @@ -374,7 +375,7 @@ export class Meta { | |||
| } | |||
|
|
|||
| writeWatching(subkey, value) { | |||
| assert(`Cannot call writeWatching after the object is destroyed.`, !this.isMetaDestroyed()); | |||
| assert(`Cannot update watchers for \`hello\` on \`${toString(this.source)}\` after it has been destroyed.`, !this.isMetaDestroyed()); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change the errors being thrown by
Metawere extremely hard to track down since no "real" information was given.After this change, all errors include the
object.toStringand property name in question (if applicable).