Release root components after they are destroyed #15513
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit removes some guards around assertions that used to fail in Glimmer. They seem to be working now 🎉
The second commit removes destroyed root components from
renderer._roots
. This was the behavior before this commit.I'm submitting this PR because retaining the destroyed components is causing trouble for me when attempting to create a new feature for ember-islands. I'd like to destroy a component and have it released so that I don't leak memory. The issue manifests in tests:
component.appendTo()
in an acceptance test.component.destroy()
.application.destroy()
) I get an errorError: Failed to execute 'removeChild' on 'Node': The node to be removed is not a child of this node.
Glimmer throws this error because Ember attempts to clean up all the
_roots
from_clearAllRoots
. However the component in_roots
has already been destroyed.