Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update blueprints and tests to RFC #176 #15552

Merged
merged 1 commit into from
Aug 16, 2017
Merged

Update blueprints and tests to RFC #176 #15552

merged 1 commit into from
Aug 16, 2017

Conversation

locks
Copy link
Contributor

@locks locks commented Jul 27, 2017

RFC #176.
Conversion tables for imports.

  • Normalize ""/'' in imports
  • Address minor documentation issues, like typos and formatting
  • Update documentation code blocks
  • Update documentation cross-linking (e.g. Ember.ApplicationInstance to ApplicationInstance)
  • Update blueprints and tests
  • Update meta-documentation (@module, @submodule, etc)

@locks locks force-pushed the comments-cleanup branch 8 times, most recently from d91037d to ee87d12 Compare July 30, 2017 09:27
@locks locks changed the title Comments cleanup Update blueprints and tests to RFC #176 Jul 30, 2017
@rwjblue
Copy link
Member

rwjblue commented Aug 7, 2017

@locks - Where are we at with this one? Seems like tests are passing now, but I'm not sure where it falls as far as completeness...

@locks
Copy link
Contributor Author

locks commented Aug 7, 2017

@rwjblue bullet list is up to date, there is some cross-linking cleanup to do which isn't blocking IMO. We need to figure out holistically how we will reference to stuff like Ember.run because it'll now be run.

@rwjblue
Copy link
Member

rwjblue commented Aug 16, 2017

OK, this looks good, can you squash?

@locks
Copy link
Contributor Author

locks commented Aug 16, 2017

@rwjblue squished.

@rwjblue rwjblue merged commit d0de6ae into master Aug 16, 2017
@rwjblue rwjblue deleted the comments-cleanup branch August 16, 2017 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants