[BUGFIX LTS] add fs-extra to deps #15606
Conversation
|
LGTM, are we worried this might be brittle? (CI wont fail) |
|
One of my workflow scripts includes |
Maybe a form of linting, saying some dir tree is depDeps another is prod only or something? That would be a way to mitigate the concern (But someone can convince me the concern is not warrented) |
kellyselden
changed the title
kellyselden
changed the title
kellyselden
changed the title
|
This should be good to go. It is better than it was previously, even though still brittle. @stefanpenner or @rwjblue merge? |
package.json
Outdated
| @@ -101,6 +101,7 @@ | |||
| "eslint-plugin-ember-internal": "^1.1.0", | |||
| "express": "^4.15.2", | |||
| "finalhandler": "^1.0.2", | |||
| "fs-extra": "^4.0.1", | |||
There was a problem hiding this comment.
I am confused. You said we are using this in blueprints, wouldn't this need to be in dependencies not devDependencies?
There was a problem hiding this comment.
That's wierd. I don't know what I was thinking. Will fix.
kellyselden
changed the title
kellyselden
force-pushed
the
fs-extra
branch
6 times, most recently
from
2bc371f to
acdd288
Compare
|
@rwjblue fixed but I can't get saucelabs to pass |
|
Ya, that’s not this PR’s issue. |
Used here and here but missing from dependencies.