Failing tests for {{partial issues in 2.15.
#15674
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
force-pushed
the
partiallllllllsssssssss!!!!!!
branch
from
d3444a0 to
1c31498
Compare
rwjblue
force-pushed
the
partiallllllllsssssssss!!!!!!
branch
from
1c31498 to
744ae7e
Compare
2 tasks
|
622de5b fixes three of the test failures |
GavinJoyce
reviewed
Oct 29, 2017
|
|
||
| this.runTask(() => set(this.context, 'items', { | ||
| items: emberA([{ id: 1 }, { id: 2 }, { id: 3 }]), | ||
| })); |
There was a problem hiding this comment.
This should be:
this.runTask(() => set(this.context, 'items',
emberA([{ id: 1 }, { id: 2 }, { id: 3 }])
));
(updated here: #15784)
GavinJoyce
reviewed
Oct 29, 2017
|
|
||
| this.runTask(() => set(this.context, 'items', { | ||
| items: emberA(['apple', 'orange', 'banana']), | ||
| })); |
There was a problem hiding this comment.
This should be:
this.runTask(() => set(this.context, 'items',
emberA([{ id: 1 }, { id: 2 }, { id: 3 }])
));
(updated here: #15784)
GavinJoyce
reviewed
Oct 29, 2017
|
|
||
| this.assertStableRerender(); | ||
|
|
||
| this.assertText('apple: apple |orange: orange |banana: banana |'); |
There was a problem hiding this comment.
as we have a null item, this should be:
this.assertText('apple: apple |: |orange: orange |banana: banana |');
(updated here: #15784)
|
now that #15784 has landed, this can be closed |
|
Fixed by @GavinJoyce in #15784 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #15621.