Commits on Oct 3, 2017

1. [BUGFIX release] Avoid creating event dispatcher in FastBoot with Eng… …

   …ines
   
   Prior to this commit, the `event_dispatcher:main` was always being
   instantiated so that it can be injected eagerly into child engines. In
   general, this is good (we should only ever have a single event
   dispatcher going) but in the FastBoot case the event dispatcher should
   not have been created at all (since there is no DOM or interactivity
   booting the event dispatcher to listen to DOM events is wasteful and
   error prone).
   
   This commit updates the EventDispatcher base class to properly look for
   the `isInteractive` flag (which is what it should have been doing all
   along) on the `-environment:main` that is injected from the
   `Application.visit` API. When `isInteractive` is falsey and the event
   dispatcher is instantiated we will issue an assertion.
   
   We also avoid eagerly looking up (and therefore forcing to initialize)
   the EventDispatcher if `.visit` API is passed `isInteractive: false`.
   This avoids the specifically reported issue of triggering an assertion
   in FastBoot mode.

   

   rwjblue committed Oct 3, 2017
   Configuration menu

   • View commit details
   • Copy full SHA for 6e9a9c1
   • Browse repository at this point

   Copy the full SHA

   6e9a9c1 View commit details

   Browse the repository at this point in the history