Typed ember glimmer #15759
Merged
Typed ember glimmer #15759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smfoote
reviewed
Oct 25, 2017
| } | ||
|
|
||
| lookupPartial(name, { owner }) { | ||
| lookupPartial(PartialName: string, meta: any): PartialDefinition<any> { |
smfoote
reviewed
Oct 26, 2017
| @@ -57,38 +57,38 @@ class OutletComponentManager extends AbstractManager<StateBucket> { | |||
| return new StateBucket(outletState); | |||
| } | |||
|
|
|||
| layoutFor(definition, bucket, env) { | |||
| layoutFor(definition, _bucket, env: Environment) { | |||
There was a problem hiding this comment.
I was wondering how to ignore some parameters.
|
Are we now doing the dangling comma? |
|
DANGLE IT |
|
@chadhietala are we not supposed to? I just did the tslint defaults and turned off the ones that seemed too cumbersome |
|
I hate it, but if we use prettier I can deal with it. |
|
We should probably use the glimmer rules (or adapt that to fit our actual
preference). Having two sets of rules for those two projects seems
confusing.
…On Thu, Oct 26, 2017 at 5:26 PM Chad Hietala ***@***.***> wrote:
I hate it, but if we use prettier I can deal with it.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#15759 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AADaFUDEaumCntxGT4yC6396Bh905ZtEks5swSNHgaJpZM4QFHBK>
.
|
For example, UpdatableTag does not have a public constructor anymore, you must use the static UpdatableTag.create now, which returns the tag in a TagWrapper.
rwjblue
force-pushed
the
typed-ember-glimmer
branch
from
a253b69 to
29689a3
Compare
|
Rebased on top of changes from #15716 (which basically introduced a conflict in all the files 😩 )... |
|
I am +1 on this. |
|
🎉 |
|
There is still work needed here, but this seems stable (and is passing CI). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15729