Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX beta] assert that classNameBinding items are non-empty strings #15940

Merged
merged 1 commit into from
Dec 7, 2017
Merged

[BUGFIX beta] assert that classNameBinding items are non-empty strings #15940

merged 1 commit into from
Dec 7, 2017

Conversation

pizza
Copy link
Contributor

@pizza pizza commented Dec 7, 2017 •
edited
Loading

This is a follow-up to a PR by @GavinJoyce (#15924)

classNameBinding items are now asserted to be strings, but can still be empty strings.

This PR fixes that, and asserts that empty strings are caught.

rwjblue
rwjblue approved these changes Dec 7, 2017
View reviewed changes
Copy link
Member

@rwjblue rwjblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for working to make this better!

@rwjblue rwjblue merged commit 1c1e7dc into emberjs:master Dec 7, 2017
@pizza pizza deleted the karim/non-empty-strings branch December 7, 2017 15:34
@pizza
Copy link
Contributor Author

pizza commented Dec 7, 2017

My first Ember.js PR 🎉 Thanks @rwjblue 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwjblue rwjblue rwjblue approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pizza @rwjblue