blueprints/util-test: Add RFC232 variants #15947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-alvarez
approved these changes
Dec 8, 2017
Turbo87
suggested changes
Dec 8, 2017
| let result = fooBar(); | ||
| assert.ok(result); | ||
| }); | ||
| }); |
snewcomer
force-pushed
the
utils-rfc232
branch
2 times, most recently
from
a9ecfbd
to
c124386
Compare
snewcomer
force-pushed
the
utils-rfc232
branch
from
c124386
to
afa52d1
Compare
rwjblue
requested changes
Dec 9, 2017
| import { setupTest } from 'ember-qunit'; | ||
|
|
||
| module('<%= friendlyTestName %>', function(hooks) { | ||
| setupTest(hooks); |
There was a problem hiding this comment.
Hmm. In general I think that we probably don’t need this? I would expect utils to invoke the util method and test its inputs and outputs. Let’s remove setupTest here for now?
|
Thank you!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress on #15933