blueprints/mixin-test: Added RFC-232 variant #15950
Conversation
| import { setupTest } from 'ember-qunit'; | ||
|
|
||
| module('Unit | Mixin | foo', function(hooks) { | ||
| setupTest(hooks); |
There was a problem hiding this comment.
I don't think we necessarily need the setupTest() call here since we're not using the container for anything 🤔
There was a problem hiding this comment.
I will remove it.
There was a problem hiding this comment.
One more question. Should I squash the commits after that, since it's a small change reverting some of this ?
There was a problem hiding this comment.
yes, I think that would be good, thanks! :)
I guess you are talking about the |
|
I got confused a bit. Yeah, I was talking about the fixture. Looking at it now it doesn't seem that necessary to add another test just for the path replacement there. Thanks a lot for the help! |
boyanyordanov
force-pushed
the
mixin-rfc232
branch
from
cd86443
to
967ce0e
Compare
|
Done. Please let me know if additional changes are needed. |
|
Awesome, thank you! |
Progress for #15933
A couple of things I am not sure about:
I wasn't sure whether the
setupTestcall is needed for mixing test (no setup was required before) and the codemod from https://github.com/rwjblue/ember-qunit-codemod didn't add it. I added it anyway, it looks logical after reading the RFC a couple of times.and also there's an addon version of this blueprint. Should there also be an updated version for rfc232 for that as well ?
P.S. Sorry If the questions are stupid. I am still learning how all this works under the hood.