Cleanup ember-template-compiler's tests

[karthiicksiva]

Related to #15988

[thoov]

Most of the time we can get rid of assert.expect(1) and I believe we can in these test cases. We will want to keep the assert.expect(0) however

[karthiicksiva]

@thoov I am not sure about how to move this? Any idea?
https://github.com/emberjs/ember.js/blob/master/packages/ember-template-compiler/tests/plugins/assert-reserved-named-arguments-test.js

//cc @rwjblue

[thoov]

@Karthiick There are a few approaches I can think of but this is what first pops to mind:

if (EMBER_GLIMMER_NAMED_ARGUMENTS) {

moduleFor('ember-template-compiler: assert-reserved-named-arguments', class extends TestCase  {

	 ['@test @arguments is reserved'](assert) {
	      assert.expectAssertion(() => {
	        compile('{{@arguments}}', { moduleName: 'baz/foo-bar' });
	      }, `'@arguments' is reserved. ('baz/foo-bar' @ L1:C2) `);
	
	      assert.expectAssertion(() => {
	        compile(`{{#if @arguments}}Yup{{/if}}`, { moduleName: 'baz/foo-bar' });
	      }, `'@arguments' is reserved. ('baz/foo-bar' @ L1:C6) `);
	
	      assert.expectAssertion(() => {
	        compile(`{{input type=(if @arguments "bar" "baz")}}`, { moduleName: 'baz/foo-bar'});
	      }, `'@arguments' is reserved. ('baz/foo-bar' @ L1:C17) `);
    }

  /* 
	... add a test property explicitly for each (I like this as its easier to grep vs saving a few lines):
    '@arguments',
    '@args',
    '@Arguments', '@Args',
    '@A', '@FOO', '@Foo',
    '@.', '@_', '@-', '@$'
*/
});

} else {

moduleFor('ember-template-compiler: assert-reserved-named-arguments', class extends TestCase {
	/*
	 Add the else tests here
	*/
});
	
}

[karthiicksiva]

Made the changes. @thoov @rwjblue

[rwjblue]

Thank you!