Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CLEANUP] Convert ember-router tests to new style #16015

Merged
merged 1 commit into from
Dec 22, 2017
Merged

[CLEANUP] Convert ember-router tests to new style #16015

merged 1 commit into from
Dec 22, 2017

Conversation

thoov
Copy link
Member

@thoov thoov commented Dec 22, 2017

Apart of #15988

During this I created a subtask on the Quest issue for us to move expectAssertion and expectDeprecation onto assert. This is just a subpart for the ember-router package so that these PRs arn't too big.

locks
locks approved these changes Dec 22, 2017
View reviewed changes
Copy link
Contributor

@locks locks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅

@locks locks merged commit 573c843 into emberjs:master Dec 22, 2017
@thoov thoov mentioned this pull request Jan 5, 2018
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@locks locks locks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thoov @locks