Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLEANUP beta] Remove Ember.Binding support #16090

Merged
merged 1 commit into from
Jan 8, 2018

Conversation

rwjblue
Copy link
Member

@rwjblue rwjblue commented Jan 8, 2018

Legacy support for the underlying feature to be moved to ember-2-legacy.

After these changes ember-2-legacy needs to do the following:

  • Set ENV._BINDING_SUPPORT to true
  • Set Ember.Mixin.finishPartial (to the function being removed)
  • Set Ember.Mixin.detectBinding (to the function being removed)

@rwjblue rwjblue force-pushed the ember-binding branch 3 times, most recently from f2934ce to 90a45f5 Compare January 8, 2018 21:50
Legacy support for the underlying feature to be moved to ember-2-legacy.

After these changes `ember-2-legacy` needs to do the following:

* Set `ENV._BINDING_SUPPORT` to `true`
* Set `Ember.Mixin.finishPartial` (to the function being removed)
* Set `Ember.Mixin.detectBinding` (to the function being removed)
@rwjblue rwjblue merged commit aa961d1 into emberjs:master Jan 8, 2018
@rwjblue rwjblue deleted the ember-binding branch January 8, 2018 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant