[BUGFIX beta] Mutating an arranged ArrayProxy is not allowed #16157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmun
force-pushed
the
array-proxy-no-mutate-arranged
branch
from
a73f809 to
8aefdfa
Compare
rwjblue
approved these changes
Jan 21, 2018
mmun
force-pushed
the
array-proxy-no-mutate-arranged
branch
from
8aefdfa to
bfc5a68
Compare
backspace
added a commit
to travis-ci/travis-web
that referenced
this pull request
May 8, 2018
The mutation of the LimitedArray was triggering this error: emberjs/ember.js#16157
backspace
added a commit
to travis-ci/travis-web
that referenced
this pull request
May 9, 2018
The way LimitedArray was being used is now forbidden in Ember 3: emberjs/ember.js#16157
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Arranged array proxies should be treated as an immutable view of the underlying data. If you want to mutate the items, you must mutate the underlying content array.
Non-arranged array proxies (i.e. that don't override the
arrangedContentdescriptor) will continue to proxy any array mutations to the underlying content array.The existing ArrayProxy code already had this behaviour for a few methods (insertAt, replace, etc). This PR normalizes the behaviour across all the
MutableArraymethods. I made sure to test this PR against ember-data master. After scanning Ember Observer, I am confident that this behaviour was not being relied on by addons.I also removed the private
nextObjectmethod that should have been removed as part of an earlier PR.