[BUGFIX beta] Fix a few bugs in the caching ArrayProxy implementation #16179
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
arrayProxy.replace(-1, 0, [obj]);
arrangedContent
observer to use privatePROPERTY_DID_CHANGE
. See the test "should update if content changes while change events are deferred" for an example of why this is needed. This was also causing the ember-data tests to fail.arrayProxy.get('length')
so that it no longer triggers the objects cache to revalidate.length
computed property to be volatile since we are handling the cache ourselves.this._objectsDirtyIndex
field is doing.undefined
.I've confirmed locally that this fixes the failing test in ember-data.