Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor CoreObject to leverage native JS semantics. #16436

Merged
merged 4 commits into from
Mar 29, 2018

Conversation

rwjblue
Copy link
Member

@rwjblue rwjblue commented Mar 28, 2018

  • Make .extend() actually use class for proper inheritance
  • Move the concepts of NAME_KEY to a weakmap
  • "prettier" some files...
  • prevent meta assertions from eagerly "to-string"ing an object (when the assertion is not going to run anyways)

@rwjblue
Copy link
Member Author

rwjblue commented Mar 28, 2018

@pzuraq - This is a slightly different approach than your PR, but has basically the same goal. When you are back in the saddle, can you rebase your tests on top of this branch and see how we do?

@rwjblue rwjblue force-pushed the core-object-es-spike branch from 559aac5 to 07ef267 Compare March 28, 2018 21:09
@rwjblue rwjblue force-pushed the core-object-es-spike branch from 07ef267 to 03dfc91 Compare March 28, 2018 21:24
@pzuraq
Copy link
Contributor

pzuraq commented Mar 29, 2018

👍this looks good based on a quick reading on my phone, will rebase the tests as soon as I’m back!

@rwjblue rwjblue merged commit 22c4e0e into master Mar 29, 2018

export function classToString() {
let name = getName(this);
if (name !== void 0) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

even if it was undefined babel would replace it to void 0, no ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I believe so

@rwjblue rwjblue deleted the core-object-es-spike branch March 29, 2018 13:04
@rwjblue
Copy link
Member Author

rwjblue commented Mar 29, 2018

#16437 enables the testing infrastructure to ensure that we stay compliant...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants