Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test runs for "pure ES<latest>" builds. #16437

Merged
merged 2 commits into from
Mar 29, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions bin/run-tests.js
Original file line number Diff line number Diff line change
Expand Up @@ -185,6 +185,9 @@ function generateEachPackageTests() {
testFunctions.push(function() {
return run('package=' + packageName);
});
testFunctions.push(function() {
return run('package=' + packageName + '&dist=es');
});
if (packages[packageName].requiresJQuery === false) {
testFunctions.push(function() {
return run('package=' + packageName + '&jquery=none');
Expand Down
4 changes: 2 additions & 2 deletions packages/ember-glimmer/tests/integration/content-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import {
getDebugFunction,
setDebugFunction
} from 'ember-debug';
import { Object as EmberObject, ObjectProxy } from 'ember-runtime';
import { Object as EmberObject, ObjectProxy, readOnly } from 'ember-runtime';
import { classes } from '../utils/test-helpers';
import { constructStyleDeprecationMessage } from 'ember-views';
import { Component, SafeString, htmlSafe } from '../utils/helpers';
Expand Down Expand Up @@ -448,7 +448,7 @@ class DynamicContentTest extends RenderingTest {

['@test it can render a readOnly property of a path']() {
let Messenger = EmberObject.extend({
message: computed.readOnly('a.b.c')
message: readOnly('a.b.c')
});

let messenger = Messenger.create({
Expand Down
7 changes: 0 additions & 7 deletions packages/ember-metal/tests/main_test.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,6 @@ import { moduleFor, AbstractTestCase } from 'internal-test-helpers';
const SEMVER_REGEX = /^((?:0|(?:[1-9]\d*)))\.((?:0|(?:[1-9]\d*)))\.((?:0|(?:[1-9]\d*)))(?:-([0-9A-Za-z-]+(\.[0-9A-Za-z-]+)*))?(?:\+([0-9A-Za-z-]+(\.[0-9A-Za-z-]+)*))?$/;

moduleFor('ember-metal/core/main', class extends AbstractTestCase {
['@test Ember registers itself'](assert) {
let lib = Ember.libraries._registry[0];

assert.equal(lib.name, 'Ember');
assert.equal(lib.version, Ember.VERSION);
}

['@test Ember.VERSION is in alignment with SemVer v2.0.0'](assert) {
assert.ok(SEMVER_REGEX.test(Ember.VERSION), `Ember.VERSION (${Ember.VERSION})is valid SemVer v2.0.0`);
}
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import ArrayProxy from '../../../system/array_proxy';
import EmberObject from '../../../system/object';
import { observer, computed } from 'ember-metal';
import { observer } from 'ember-metal';
import { oneWay as reads } from 'ember-runtime';
import { A as a } from '../../../mixins/array';

QUnit.module('Ember.ArrayProxy - content change (length)');
Expand All @@ -11,8 +12,8 @@ QUnit.test('array proxy + aliasedProperty complex test', function(assert) {
aCalled = bCalled = cCalled = dCalled = eCalled = 0;

let obj = EmberObject.extend({
colors: computed.reads('model'),
length: computed.reads('colors.length'),
colors: reads('model'),
length: reads('colors.length'),

a: observer('length', () => aCalled++),
b: observer('colors.length', () => bCalled++),
Expand Down
3 changes: 2 additions & 1 deletion packages/ember-runtime/tests/system/object/computed_test.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import {
observer,
defineProperty
} from 'ember-metal';
import { oneWay as reads } from 'ember-runtime';
import { testWithDefault } from 'internal-test-helpers';
import EmberObject from '../../../system/object';

Expand Down Expand Up @@ -300,7 +301,7 @@ QUnit.test('Calling _super in apply outside the immediate function of a CP gette

QUnit.test('observing computed.reads prop and overriding it in create() works', function(assert) {
let Obj = EmberObject.extend({
name: computed.reads('model.name'),
name: reads('model.name'),
nameDidChange: observer('name', function() {})
});

Expand Down