[bugfix] Fix proto return value for native classes
#16516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Native classes end up calling the nearest class constructor, and with the recent refactor those class constructors return their own prototype instead of the class instance's. This breaks certain functions that currently rely on the `proto` function return the prototype of the instance itself. We're seeing failures in `@ember-decorators/data` due to this bug. This reverts to returning the protoype on the instance directly.
pzuraq
force-pushed
the
bugfix/fix-proto-return-value
branch
from
47e6aee to
c93adc0
Compare
|
Thank you! |
|
Any chance this could be cherry-picked onto beta? Still having failures for data decorators on the beta branch now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Native classes end up calling the nearest class constructor, and with
the recent refactor those class constructors return their own prototype
instead of the class instance's. This breaks certain functions that
currently rely on the
protofunction return the prototype of theinstance itself. We're seeing failures in
@ember-decorators/datadue to this bug.
This reverts to returning the protoype on the instance directly.
The other option would be to instead make
protoa purely side-effectingfunction that doesn't return anything, and change the instances where
it is called to use the prototype of the instance they are calling it on. Unsure
if there are any perf implications here.
cc @rwjblue @krisselden