[BUGFIX beta] support mouseEnter/Leave events w/o jQuery #16603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
btecu
reviewed
May 3, 2018
|
|
||
| let parent = this.element; | ||
| let outer = this.$('#outer')[0]; | ||
| let inner = this.$('#inner')[0]; |
simonihmig
force-pushed
the
support-mouseenter
branch
from
34a2ddf to
e730fba
Compare
simonihmig
force-pushed
the
support-mouseenter
branch
3 times, most recently
from
e752fd4 to
18c1dac
Compare
As these events don't bubble, the `EventDispatcher`'s event delegation approach does not work here, when not using jQuery. jQuery has special handling of these events, by listening to `mouseover`/`mouseout` instead and dispatching fake `mouseenter`/`mouseleave` events. This adds similar handling to `EventDispatcher`'s native mode for these events. Fixes emberjs#16591
simonihmig
force-pushed
the
support-mouseenter
branch
from
18c1dac to
7aa1ae7
Compare
|
I rebased this today (had conflicts with my own jQuery.Event deprecation changes 😝). This should be green, but I always get some failing test runs due to yarn network timeouts. Already force pushed a few times to rerun the tests... @rwjblue @krisselden would love a review! :) |
|
restarted those failed builds, will try to do a proper review today. Sorry for the delays... |
|
No problem, at least it's green now! :) |
|
will this land in 3.4? or maybe in 3.3? |
|
@rwjblue ping ;) |
|
@rwjblue can I help with this? |
rwjblue
approved these changes
Aug 10, 2018
ilucin
reviewed
Aug 30, 2018
| event.stopPropagation(); | ||
| break; | ||
| } | ||
| } else if (target.hasAttribute('data-ember-action')) { |
There was a problem hiding this comment.
target can be a text node which does not support hasAttribute method -> http://take.ms/vCrm8C
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As these events don't bubble, the
EventDispatcher's event delegation approach does not work here, when not using jQuery. jQuery has special handling of these events, by listening tomouseover/mouseoutinstead and dispatching fakemouseenter/mouseleaveevents. This adds similar handling toEventDispatcher's native mode for these events.Fixes #16591