Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap all existing deprecated features for svelting. #16685

Merged
merged 16 commits into from
May 25, 2018

Conversation

rwjblue
Copy link
Member

@rwjblue rwjblue commented May 24, 2018

No description provided.

@rwjblue rwjblue requested a review from krisselden May 24, 2018 19:36
@rwjblue rwjblue force-pushed the more-deprecation-flags branch from 1d0024a to 3313226 Compare May 24, 2018 21:43
@@ -390,67 +391,75 @@ export class Meta {
}

writeBindings(subkey: string, value: any) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe conditionally extend meta like done here: #16355

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would you mind updating that PR to fix it up? I do agree that is nice

Copy link
Contributor

@krisselden krisselden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe cleaner to do what @bekzod mentioned.

@rwjblue rwjblue merged commit 6fc89cd into emberjs:master May 25, 2018
@rwjblue rwjblue deleted the more-deprecation-flags branch May 25, 2018 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants