Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC 322] Implemented copy/Copyable deprecation #16692

Merged
merged 2 commits into from
May 26, 2018
Merged

[RFC 322] Implemented copy/Copyable deprecation #16692

merged 2 commits into from
May 26, 2018

Conversation

lupestro
Copy link

At long last, I finally delivered an implementation of the RFC. Sorry for the delay.

  • Take a close look at the substitution of a shallow copy for a deep one on the three affected tests in decoupled_basic_test. If we have to do a deep copy for the test to be valid, I'll have to research what's needed.
  • I explicitly made copy private - hopefully that's okay. Copyable had always been private.

rwjblue
rwjblue approved these changes May 26, 2018
View reviewed changes
Copy link
Member

@rwjblue rwjblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I’m going to land this and we can work on the svelting stuff in a follow up...

@rwjblue rwjblue merged commit 8db4843 into emberjs:master May 26, 2018
@rwjblue
Copy link
Member

rwjblue commented May 26, 2018

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwjblue rwjblue rwjblue approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lupestro @rwjblue