[BUGFIX beta] Throw error if run.bind receives no method #16729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Serabe
force-pushed
the
fix/16652/run-bind-error
branch
2 times, most recently
from
d347b61 to
ae7fef6
Compare
rwjblue
reviewed
Jun 8, 2018
packages/@ember/runloop/index.js
Outdated
| export const bind = (...curried) => (...args) => join(...curried.concat(args)); | ||
| export const bind = (...curried) => { | ||
| if (!bindMethodPresent(...curried)) { | ||
| throw new Error('could not find a suitable method to bind'); |
There was a problem hiding this comment.
Can we make this an assertion and inline the bindMethodPresent implementation in an IIFE as the predicate?
assert('Could not find a suitable method to bind.', (function() {
// guts of conditional below...
})());
|
No problem. I used an error because it was what was requested, but can
easily be done.
…On 8 June 2018 at 22:00:54, Robert Jackson ***@***.***) wrote:
***@***.**** commented on this pull request.
------------------------------
In ***@***.***/runloop/index.js
<#16729 (comment)>:
> @@ -217,7 +217,39 @@ export function join() {
@SInCE 1.4.0
@public
*/
-export const bind = (...curried) => (...args) => join(...curried.concat(args));
+export const bind = (...curried) => {
+ if (!bindMethodPresent(...curried)) {
+ throw new Error('could not find a suitable method to bind');
Can we make this an assertion and inline the bindMethodPresent
implementation in an IIFE as the predicate?
assert('Could not find a suitable method to bind.', (function() {
// guts of conditional below...
})());
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#16729 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AACNfZQbH_6vesaZj8ZkL4TtPQDQsnPMks5t6tf2gaJpZM4UgjhZ>
.
|
Yeah, sorry about that. I had forgotten just how complicated the argument munging is for |
Serabe
force-pushed
the
fix/16652/run-bind-error
branch
from
ae7fef6 to
5b22bf5
Compare
This commit uses the same logic as backburner.join to know which method is being bound. Fixes emberjs#16652
Serabe
force-pushed
the
fix/16652/run-bind-error
branch
from
5b22bf5 to
3329f09
Compare
|
Done! |
rwjblue
approved these changes
Jun 10, 2018
|
Thank you!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit uses the same logic as backburner.join to know
which method is being bound.
Fixes #16652