[BUGFIX] observed properties not being marked as enum #16735
Conversation
bekzod
force-pushed
the
fix-object-key
branch
2 times, most recently
from
b5e6530
to
2cbd94d
Compare
| @@ -93,6 +93,28 @@ moduleFor( | |||
| getOwner(proxy); | |||
| } | |||
|
|
|||
| ['@test `Object.keys` works properly'](assert) { | |||
There was a problem hiding this comment.
Can you tweak this test title? I'd like to see it reference the original issue, and specifically what it is intended to test.
Something like this seems reasonable:
@test observed properties are enumerable when set GH#14594
Also, can you move this to two tests one in packages/ember-metal/tests/accessors/set_test.js and another in packages/ember-metal/tests/set_properties_test.js?
bekzod
force-pushed
the
fix-object-key
branch
2 times, most recently
from
8fbf9c9
to
04c48cb
Compare
| @@ -1,4 +1,5 @@ | |||
| import { setProperties } from '..'; | |||
| import { CoreObject } from 'ember-runtime'; | |||
There was a problem hiding this comment.
In general we shouldn't be importing from ember-runtime from within ember-metal.
The tests in ember-metal will need to be updated to use POJO's instead of CoreObject...
There was a problem hiding this comment.
Issue does not happen with POJO objects it only happens with CoreObject, so moving back to CoreObject test
bekzod
force-pushed
the
fix-object-key
branch
2 times, most recently
from
02bcae9
to
f3eca1c
Compare
bekzod
force-pushed
the
fix-object-key
branch
from
f3eca1c
to
905f6db
Compare
bekzod
force-pushed
the
fix-object-key
branch
from
905f6db
to
79494e2
Compare
|
Sorry it took so long here, but this looks good to me. Thanks again @bekzod! |
fixes #14594