[BUGFIX release] Clear chains in ProxyMixin when destroyed #16860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
reviewed
Aug 3, 2018
| @@ -61,6 +61,11 @@ export default Mixin.create({ | |||
| m.writableTag(() => combine([DirtyableTag.create(), UpdatableTag.create(CONSTANT_TAG)])); | |||
| }, | |||
|
|
|||
| destroy() { | |||
| this._super(...arguments); | |||
| this.set('content', null); | |||
There was a problem hiding this comment.
I'd prefer to set the content before supering. Do you see any issues with that?
|
@rwjblue no problem, just left on a long weekend, will do it next Thursday
Op vr 3 aug. 2018 16:05 schreef Robert Jackson <notifications@github.com>:
… ***@***.**** commented on this pull request.
------------------------------
In packages/ember-runtime/lib/mixins/-proxy.js
<#16860 (comment)>:
> @@ -61,6 +61,11 @@ export default Mixin.create({
m.writableTag(() => combine([DirtyableTag.create(), UpdatableTag.create(CONSTANT_TAG)]));
},
+ destroy() {
+ this._super(...arguments);
+ this.set('content', null);
I'd prefer to set the content before supering. Do you see any issues with
that?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#16860 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AGwv8hD0MW9757n8Qkz0g6OtAZX4gID-ks5uNFiKgaJpZM4Vt37u>
.
|
|
Awesome, enjoy!
|
krisselden
requested changes
Aug 4, 2018
krisselden
approved these changes
Aug 15, 2018
|
Sorry for the delays, the repo reorganization has caused conflicts here would you mind rebasing? |
|
rebased |
rwjblue
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a ObjectProxy is destroyed while the proxied object is still alive, then the ObjectProxy is leaked because the chains attached to the proxied object retains the ObjectProxy.
This is an issue for us, as ember-data uses proxies for their belongsTo relationships. (See emberjs/data#5554 for more information)
A sample program that demonstrates this can be found at https://github.com/pieter-v/ember-proxy-leak
A memory snapshot before this fix:
A memory snapshot after this fix:
