Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLEANUP] Allow routes to be named "array" and "object" #16877

Merged
merged 2 commits into from
Aug 13, 2018

Conversation

camerondubas
Copy link
Contributor

Hey all 👋 this is my first PR to Ember!

This resolves #16872 by removing "array" as a reserved route name.

@@ -26,7 +26,7 @@ class DSL {
return true;
}

return ['array', 'basic', 'object', 'application'].indexOf(name) === -1;
return ['basic', 'object', 'application'].indexOf(name) === -1;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also remove object? It was essentially the same boat as array and should die too...

@camerondubas camerondubas changed the title [CLEANUP] Allow routes to be named "array" [CLEANUP] Allow routes to be named "array" and "object" Aug 12, 2018
@camerondubas
Copy link
Contributor Author

@rwjblue Updated

@locks
Copy link
Contributor

locks commented Aug 13, 2018

All green, thank you!

@locks locks merged commit ca4d13c into emberjs:master Aug 13, 2018
@rwjblue
Copy link
Member

rwjblue commented Sep 4, 2018

Thank you @camerondubas!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow routes named “array”
3 participants