[BUGFIX] isEmpty on nested objects #16879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
reviewed
Dec 19, 2018
packages/ember-metal/lib/is_empty.ts
Outdated
| let length = get(obj, 'length'); | ||
| if (typeof length === 'number') { | ||
| return !length; | ||
| } | ||
| } | ||
|
|
||
| if (typeof obj.length === 'number' && objectType !== 'function') { |
There was a problem hiding this comment.
Hmm, do we even need this check anymore?
There was a problem hiding this comment.
This is what allows an empty string ('') to be marked as empty.
This comment has been minimized.
This comment has been minimized.
|
@janvotava do you have some time to pick this back up? 😅 |
So ArrayProxy inside ObjectProxy works with ES5 getters Fixes emberjs#16878
wagenet
force-pushed
the
fix-isEmpty-on-nested
branch
from
053db77 to
4d02c25
Compare
|
@janvotava @locks I rebased this for you. |
|
@locks I'm sorry. What exactly do you mean by that? 😅 |
|
All is good, @wagenet took care of it :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So ArrayProxy inside ObjectProxy works with ES5 getters and there's no
Assertion Failed: You attempted to access the 'length' propertyerror.Fixes #16878