[FEATURE Router Service] recognize and recognizeAndLoad #17034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 tasks
chadhietala
force-pushed
the
recognize-apis
branch
from
e15799b to
52e5f18
Compare
chadhietala
commented
Oct 3, 2018
| @@ -266,6 +267,43 @@ if (EMBER_ROUTING_ROUTER_SERVICE) { | |||
| this.trigger('routeDidChange', transition); | |||
| }); | |||
| }, | |||
|
|
|||
| // Uncomment this when we go the feature | |||
There was a problem hiding this comment.
Will use @category
chadhietala
force-pushed
the
recognize-apis
branch
from
52e5f18 to
2dabdd5
Compare
rwjblue
approved these changes
Oct 3, 2018
chadhietala
force-pushed
the
recognize-apis
branch
from
2dabdd5 to
d6e899c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces 2 new methods to the router service.
recognize: Takes a string URL and returns aRouteInfofor the leafmost route represented by the URL. Returns null if the URL is not recognized. This method expects to receive the actual URL as seen by the browser including the app'srootURL.recognizeAndLoad: Takes a string URL and returns a promise that resolves to aRouteInfoWithAttributesfor the leafmost route represented by the URL. The promise rejects if the URL is not recognized or an unhandled exception is encountered. This method expects to receive the actual URL as seen by the browser including the app'srootURL.This rounds out all APIs on the router service.