[FEATURE Router Service] Deprecate touching transition state #17038
Conversation
| @@ -219,7 +226,7 @@ class Route extends EmberObject implements IRoute { | |||
| } | |||
|
|
|||
| let transition = this._router._routerMicrolib.activeTransition; | |||
| let state = transition ? transition.state : this._router._routerMicrolib.state; | |||
| let state = transition ? transition[STATE_SYMBOL] : this._router._routerMicrolib.state; | |||
There was a problem hiding this comment.
I think you might be confused. transition.state is still needed internally but access to it from application code should be deprecated and we just tell people to use the RouteInfo. All of these symbols are just allowing the integration of ember-router and router.js to work. I could have simply renamed the method but I felt that using a faux-symbol may deter people further. In the future we should just make these real symbols.
There was a problem hiding this comment.
👍 thank you!
some of the comments though are specifically about deprecations, and should still apply
| @@ -899,10 +906,10 @@ class Route extends EmberObject implements IRoute { | |||
|
|
|||
| if (transition) { | |||
| // Update the model dep values used to calculate cache keys. | |||
| stashParamNames(this._router, transition.state!.routeInfos); | |||
| stashParamNames(this._router, transition[STATE_SYMBOL]!.routeInfos); | |||
|
|
||
| let cache = this._bucketCache; | ||
| let params = transition.params; | ||
| let params = transition[PARAMS_SYMBOL]; |
| @@ -1152,7 +1159,7 @@ class Route extends EmberObject implements IRoute { | |||
| if (transition.resolveIndex < 1) { | |||
| return; | |||
| } | |||
| return transition.state!.routeInfos[transition.resolveIndex - 1].context; | |||
| return transition[STATE_SYMBOL]!.routeInfos[transition.resolveIndex - 1].context; | |||
There was a problem hiding this comment.
Svelting? What do we return after the deprecation?
There was a problem hiding this comment.
No where this is returning the context aka the result of the model hook
| @@ -73,6 +76,56 @@ function defaultWillTransition( | |||
| } | |||
| } | |||
|
|
|||
| if (TRANSITION_STATE) { | |||
There was a problem hiding this comment.
This is a svelte import.
This deprecates access to the
state,paramsandqueryParamsfields on theTransitionthat were private but became defacto public API since there was no other way to access it. The router service will exposeRouteInfoobjects which is the public object that has this state on it.