[WIP] Trigger Ember Inspector Travis build #17182
Conversation
| @@ -93,6 +94,16 @@ jobs: | |||
| - env: | |||
| - TEST_SUITE=each-package-tests | |||
|
|
|||
| - stage: inspector tests | |||
| jdk: oraclejdk8 | |||
| echo "TRAVIS_BRANCH=$TRAVIS_BRANCH TRAVIS_PULL_REQUEST=$TRAVIS_PULL_REQUEST" | ||
| if [[ ($TRAVIS_BRANCH == master) && | ||
| ($TRAVIS_PULL_REQUEST == false) ]] ; then | ||
| curl -LO --retry 3 https://raw.github.com/mernst/plume-lib/master/bin/trigger-travis.sh |
|
FWIW, I'm not certain that we want this conceptually, the cron jobs that already run ember-inspector's test suite against canary nightly should be enough as long as we "pay attention" to them... |
|
@rwjblue well we are currently unable to merge anything into inspector, since we're blocked on the beta and canary failures, and I do not know what in Ember is causing the failures, so it would be nice to not introduce the failures in the first place. I'm fine with relying on the cron job, if I can get some dedicated Ember core resources to help me figure out why things broke 😃 |
|
Best way to get this sort of help is to open an issue when the cron jobs show a problem. I spent a decent amount of time tracking down when the failure was introduced (and isolating a few possible PR's) but since there was no issue to share the info in it was lost to the ether... |
|
Thankfully, we still have the history (yea discord!): https://discordapp.com/channels/480462759797063690/485447409296736276/508006008451497984 |
|
https://travis-ci.org/emberjs/ember-inspector/builds/443679382 - passed canary (18 days ago) There were a few PR's that landed around that time frame: |
|
Closing for now. We can readdress if we really feel that we need to, but I'm hopeful that the cron jobs in ember-inspector are enough of an early warning system for us... |
This is an attempt at making sure we don't allow inspector tests to fail during updates to Ember. Assuming this runs, we'll also need to make some changes on the inspector side to run against the commit hash from the PR.