[BUGFIX beta] Reverts EmberError to be a standard function #17233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
approved these changes
Nov 28, 2018
|
@pzuraq can you mark this as BUGFIX beta? |
This reverts a change from some years ago that made EmberError a native class. The recent change to build non-transpiled classes is causing failures in libraries that subclass EmberError (specifically Ember Data) and with the messiness around how EmberError actually does the extending, using native classes is not ideal. Eventually, EmberError should be replaced entirely as it is not a good idea to subclass Error at all. This will have to happen in the future, and will likely require an RFC.
pzuraq
force-pushed
the
bugfix/revert-ember-error-to-standard-function
branch
from
d8556c9
to
bbc4647
Compare
pzuraq
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts a change from some years ago that made EmberError a native
class. The recent change to build non-transpiled classes is causing
failures in libraries that subclass EmberError (specifically Ember Data)
and with the messiness around how EmberError actually does the
extending, using native classes is not ideal.
Eventually, EmberError should be replaced entirely as it is not a good
idea to subclass Error at all. This will have to happen in the future,
and will likely require an RFC.