-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUGFIX beta] Adds early Android versions to legacy target list #17246
[BUGFIX beta] Adds early Android versions to legacy target list #17246
Conversation
45e7565
to
b4d289b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, this seems much less brittle!
"chalk": "^2.3.0", | ||
"ember-cli-babel": "^7.1.3", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are we sure that this does not cause any unintended side-effects? 1. because ember-cli-babel
might do something at app-buildtime and 2. because it's Babel 7, but we're still using Babel 6 to build the Ember.js assets
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My understanding is that ember-cli-babel
will only apply to addon source code, so ember-source
s addon code, which doesn't exist. There's definitely the discrepancy with Babel 6, but since that is a _pre_publish step and fundamentally disconnected from ember-cli-babel
, I figured it would make more sense to use the latest Babel instead. We can change this though if it seems problematic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, I just looked at https://unpkg.com/ember-source@3.5.1/lib/index.js, and this does indeed seem safe to do.
The browserstack failures seem related (this CI job):
|
b4d289b
to
6512a5a
Compare
Currently, we only check for IE compatibility, but legacy Android browsers can also cause an issue. In general we need to solve this by respecting the browser targets of the client, but that will require more thorough changes to our build to actually use modules and drop bundling altogether.