Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Impl. buildRouteInfoMetadata #17256

Merged
merged 2 commits into from
Dec 10, 2018
Merged

Conversation

chadhietala
Copy link
Contributor

@chadhietala chadhietala commented Dec 5, 2018

This introduces buildRouteInfoMetadata as specified by RFC#398

@chadhietala chadhietala force-pushed the impl-build-routeinfo-metadata branch from 6e208c1 to c0accdc Compare December 10, 2018 15:01
@chadhietala chadhietala changed the title [WIP FEATURE] Impl. buildRouteInfoMetadata [FEATURE] Impl. buildRouteInfoMetadata Dec 10, 2018
@chadhietala chadhietala requested a review from rwjblue December 10, 2018 15:26
@chadhietala chadhietala force-pushed the impl-build-routeinfo-metadata branch from 7ee84aa to 56d74e0 Compare December 10, 2018 17:12
@rwjblue
Copy link
Member

rwjblue commented Dec 10, 2018

not ok 2 Docs coverage > classitems > No extraneous classitems
  ---
  message: "If you intentionally removed a public API method, please udpate tests/docs/expected.js. Otherwise, documentation is missing, incorrectly formatted, or in a directory that is not watched by yuidoc. All files containing documentation must have a yuidoc class declaration."
  severity: failed
  actual: [
  "metadata"
]
  expected: []
  stack:     at Object.<anonymous> (/home/travis/build/emberjs/ember.js/tests/docs/coverage-test.js:33:14)
  ...
1..2
# pass 1
# skip 0
# todo 0
# fail 1
error Command failed with exit code 1.

I think you need to add a new entry to the fixture of all the "classitems".

@chadhietala chadhietala force-pushed the impl-build-routeinfo-metadata branch from 56d74e0 to cf2ae90 Compare December 10, 2018 17:22
@rwjblue rwjblue merged commit de301b6 into master Dec 10, 2018
@rwjblue rwjblue deleted the impl-build-routeinfo-metadata branch December 10, 2018 18:06
@rwjblue
Copy link
Member

rwjblue commented Dec 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants