Allow notifyPropertyChange to be imported from @ember/object #17357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
approved these changes
Dec 12, 2018
|
ember-cli-babel@6.18.0 and ember-cli-babel@7.2.0 have been published allowing this import. |
This was referenced Dec 12, 2018
sukima
reviewed
Aug 7, 2020
| @@ -31,6 +31,7 @@ let deferred = 0; | |||
| @param {String} keyName The property key (or path) that will change. | |||
| @param {Meta} meta The objects meta. | |||
| @return {void} | |||
| @since 3.1.0 | |||
There was a problem hiding this comment.
This marks this available since 3.1.0 but this commit (and the one exposing the export from @ember/object is not in a tag till v3.8.0-beta.1. How does that work?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: ember-cli/ember-rfc176-data#84