Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX beta] remove jQuery deprecation code from production builds #17555

Merged
merged 1 commit into from
Feb 16, 2019

Conversation

simonihmig
Copy link
Contributor

I confirmed by looking at ember.min.js that the Proxy code is indeed stripped.

Fixes #17550

@rwjblue
Copy link
Member

rwjblue commented Feb 3, 2019

Thank you!

@simonihmig
Copy link
Contributor Author

Not sure what's failing the tests here for IE and Edge ("multiple calls to next share coalesce callbacks into same run loop"), but it seems unrelated!?

@rwjblue
Copy link
Member

rwjblue commented Feb 16, 2019

I doubt that the failure is related. I've restarted it.

@simonihmig
Copy link
Contributor Author

@rwjblue thanks! Green now! :)

@rwjblue rwjblue merged commit 5e4edde into emberjs:master Feb 16, 2019
@kategengler
Copy link
Member

This is marked 'Bugfix beta', the code it modified has a previous commit that isn't in beta #17525

@simonihmig simonihmig deleted the fix-jquery-deprecation-debug branch March 8, 2019 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants