Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX] avoid tampering queryParam argument in RouterService#isActive #17571

Merged
merged 1 commit into from
May 27, 2020
Merged

[BUGFIX] avoid tampering queryParam argument in RouterService#isActive #17571

merged 1 commit into from
May 27, 2020

Conversation

bekzod
Copy link
Contributor

@bekzod bekzod commented Feb 6, 2019 •
edited
Loading

using same query param hash twice would fail in RouterService#isActive

@locks locks requested review from chadhietala and rwjblue April 19, 2020 11:53
rwjblue
rwjblue approved these changes May 23, 2020
View reviewed changes
Copy link
Member

@rwjblue rwjblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes seem good to me, mind rebasing (to make sure things are all happy with current linting settings and whatnot)?

@locks locks self-assigned this May 23, 2020
@bekzod bekzod changed the title [BUGFIX] don't alter queryParam argument in RouterService#isActive [BUGFIX] avoid tampering queryParam argument in RouterService#isActive May 27, 2020
@bekzod
Copy link
Contributor Author

bekzod commented May 27, 2020

I rebased it and tests seem to pass

@chancancode chancancode merged commit 8cf2995 into emberjs:master May 27, 2020
@chancancode
Copy link
Member

Thanks!

@bekzod bekzod deleted the fix-is-active branch May 27, 2020 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@locks locks locks approved these changes

@rwjblue rwjblue rwjblue approved these changes

@chadhietala chadhietala Awaiting requested review from chadhietala

Assignees

@locks locks

Labels
Query Params Routing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bekzod @chancancode @rwjblue @locks