Angle bracket blueprint #17685
Merged
Angle bracket blueprint #17685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this change, the blueprints generated curly brace syntax for the component-test. This change will default to generating the angle bracket syntax unless it finds the component being generated has any nesting (which is not supported by angle bracket syntax) in which case it fallsback to the curly bracket syntax. Fixes emberjs#17625 Based on an original implementation by @ppcano
Prior to this change, the command `ember g component x-foo --path foo` was originally producing angle bracket syntax but this seems incorrect and should be the full nested invocation and curly bracket syntax. This change fixes that oversight. Issue found and discussed with @ppcano via Discord.
rwjblue
approved these changes
Mar 2, 2019
|
Thank you! |
simonihmig
added a commit
to simonihmig/ember.js
that referenced
this pull request
Mar 16, 2019
Removes incidental use of QUnit's `assert()` introduced in emberjs#17685.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR supersedes #17666 and attempts to address issue #17625
When generating the blueprints for a component the component-test blueprint will attempt to generate a test that uses Angle Bracket Syntax unless it sees that the component is nested in a path requiring the generated test to fallback and use Curly Bracket Syntax.