Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for nested components in angle bracket invocation syntax #17719

Merged
merged 1 commit into from
Mar 13, 2019

Conversation

tomdale
Copy link
Member

@tomdale tomdale commented Mar 8, 2019

This is an implementation of the Nested Invocations in Angle Bracket Syntax RFC. It enables invoking components nested inside directories with angle bracket invocation syntax.

For example, if a component exists in app/templates/components/foo-bar/baz-bang, you can invoke it with curlies like this:

{{foo-bar/baz-bang}}

This PR adds support for invoking that same component with angle brackets like this:

<FooBar::BazBang />

The feature is added behind the EMBER_GLIMMER_ANGLE_BRACKET_NESTED_LOOKUP feature flag.

@rwjblue
Copy link
Member

rwjblue commented Mar 8, 2019

Has conflicts with the PR just merged (which removes some of the other previously enabled features).

@tomdale
Copy link
Member Author

tomdale commented Mar 8, 2019

@rwjblue Sorry, will fix.

@rwjblue
Copy link
Member

rwjblue commented Mar 8, 2019

Also, I'd strongly prefer coming to a conclusion in the RFC before implementing (unless we are also accepting a feature enabling the same feature with /).

@tomdale tomdale force-pushed the angle-bracket-nested-lookups branch from b48a101 to 6c764a6 Compare March 8, 2019 02:01
See emberjs/rfcs#457 for RFC.
This feature is added beind the EMBER_GIMMER_ANGLE_BRACKET_NESTED_LOOKUP feature flag.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants