Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE ember-glimmer-angle-bracket-nested-lookup] enable 👌 #17745

Merged
merged 2 commits into from
Mar 17, 2019

Conversation

chancancode
Copy link
Member

@chancancode chancancode commented Mar 15, 2019

We discussed it in the core team meeting today and decided to "GO" the feature. However, due to EmberConf travels, we didn't have everyone in the meeting so I am waiting a day or so to see if there are any objections from other team members.

Copy link
Member

@rwjblue rwjblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤢

@chancancode chancancode requested a review from locks March 15, 2019 21:19
@wycats wycats force-pushed the enable-nested-angle branch from 6677f1f to cf0b972 Compare March 16, 2019 22:35
@chancancode chancancode requested a review from jenweber March 16, 2019 22:40
Copy link
Contributor

@jenweber jenweber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! This is exactly what I meant by showing both angle bracket and curly syntax.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants