-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix native DOM events in Glimmer Angle Brackets #17788
Conversation
Thank you! Can you also add it to the angle bracket file? |
381dda0
to
d7e8623
Compare
d7e8623
to
08234b8
Compare
Disabling the tagless action test and adding |
08234b8
to
4df1b0f
Compare
ff4a8f4
to
d7f9ebe
Compare
@@ -148,6 +148,11 @@ if (EMBER_GLIMMER_ANGLE_BRACKET_BUILT_INS) { | |||
Input = Component.extend({ | |||
tagName: '', | |||
|
|||
init() { | |||
this[DISABLE_TAGLESS_EVENT_CHECK] = true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wrap this in if (DEBUG) { ... }
36c22f6
to
5036e15
Compare
@chancancode looks like some of these events don't work in some of the browser tests. How should we handle this? |
Maybe create a regular component, go through the loop and identify what is
supposed to work, and use that list for the test
…On Thu, Mar 21, 2019 at 10:54 AM Peter Wagenet ***@***.***> wrote:
@chancancode <https://github.com/chancancode> looks like some of these
events don't work in some of the browser tests. How should we handle this?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#17788 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AADaFdUIkbLJOy0nnxlWTgYrVholE8Ckks5vY8dhgaJpZM4b_rqb>
.
|
@chancancode I think the issue is that different browsers support different events. |
Yes. I mean do that inside your test. Step 1: register a normal component and render it, do the loop you have now and collect the list of supported events without any assertions. Step 2: loop through that smaller list and assert on the input component t |
4541bb7
to
f7ac046
Compare
f7ac046
to
3288354
Compare
Refactor #17788 to internally forward all the args (essentially `...@args`) in the component manager layer instead.
Refactor #17788 to internally forward all the args (essentially `...@args`) in the component manager layer instead.
Refactor #17788 to internally forward all the args (essentially `...@args`) in the component manager layer instead.
No description provided.