Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix native DOM events in Glimmer Angle Brackets #17788

Merged
merged 1 commit into from
Mar 22, 2019

Conversation

wagenet
Copy link
Member

@wagenet wagenet commented Mar 20, 2019

No description provided.

@chancancode
Copy link
Member

Thank you! Can you also add it to the angle bracket file?

.travis.yml Outdated Show resolved Hide resolved
@wagenet
Copy link
Member Author

wagenet commented Mar 20, 2019

Disabling the tagless action test and adding @input={{@input}} to the template resolves this. Of course, disabling the check isn't a long term solution. Also, are there any other events that have this same issue?

@wagenet wagenet changed the title Add failing test for angle bracket input event Fix native DOM events in Glimmer Angle Brackets Mar 20, 2019
@wagenet wagenet force-pushed the failing-angle-input-test branch 4 times, most recently from ff4a8f4 to d7f9ebe Compare March 20, 2019 20:48
@@ -148,6 +148,11 @@ if (EMBER_GLIMMER_ANGLE_BRACKET_BUILT_INS) {
Input = Component.extend({
tagName: '',

init() {
this[DISABLE_TAGLESS_EVENT_CHECK] = true;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrap this in if (DEBUG) { ... }

@wagenet wagenet force-pushed the failing-angle-input-test branch 2 times, most recently from 36c22f6 to 5036e15 Compare March 20, 2019 22:55
@wagenet
Copy link
Member Author

wagenet commented Mar 21, 2019

@chancancode looks like some of these events don't work in some of the browser tests. How should we handle this?

@chancancode
Copy link
Member

chancancode commented Mar 21, 2019 via email

@wagenet
Copy link
Member Author

wagenet commented Mar 21, 2019

@chancancode I think the issue is that different browsers support different events.

@chancancode
Copy link
Member

Yes. I mean do that inside your test. Step 1: register a normal component and render it, do the loop you have now and collect the list of supported events without any assertions. Step 2: loop through that smaller list and assert on the input component t

@wagenet wagenet force-pushed the failing-angle-input-test branch 2 times, most recently from 4541bb7 to f7ac046 Compare March 21, 2019 19:30
@wagenet wagenet merged commit 707a938 into emberjs:master Mar 22, 2019
@wagenet wagenet deleted the failing-angle-input-test branch March 22, 2019 17:57
chancancode added a commit that referenced this pull request Mar 26, 2019
Refactor #17788 to internally forward all the args (essentially `...@args`)
in the component manager layer instead.
chancancode added a commit that referenced this pull request Mar 26, 2019
Refactor #17788 to internally forward all the args (essentially `...@args`)
in the component manager layer instead.
chancancode added a commit that referenced this pull request Mar 26, 2019
Refactor #17788 to internally forward all the args (essentially `...@args`)
in the component manager layer instead.
rwjblue added a commit that referenced this pull request Mar 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants