Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE ember-glimmer-angle-bracket-built-ins] Add missing dependent key #17814

Merged
merged 1 commit into from
Mar 29, 2019

Conversation

chancancode
Copy link
Member

There are no failing tests for this at the moment, because we only test with all optional features on or off. It turns out that the tracked property feature is masking this failure. As a result, the PR that enables this feature (#17811) without tracked property has some failing tests which should be green again after rebasing on top of this patch.

Add missing dependent key

There are no failing tests for this at the moment, because we only
test with all optional features on or off. It turns out that the
tracked property feature is masking this failure. As a result, the
PR that enables this feature (#17811) without tracked property has
some failing tests which should be green again after rebasing on
top of this patch.
@chancancode chancancode merged commit 8ad9bbc into master Mar 29, 2019
@chancancode chancancode deleted the missing-href-dep-key branch March 29, 2019 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants