[FEAT] Makes the @action decorator work in classic classes #17827
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the new
@action
decorator is the only decorator in Emberproper that doesn't work in classic classes currently. Since users could
define actions on the actions hash in classic classes, we didn't
originally see a reason for it to work in classic classes. However, with
the fact that the decorator now binds context, it may actually become
useful for users, especially if they decide to convert away from the
{{action}}
modifier/helper.Additionally, this makes them match up with our learning story for the
rest of decorators - they're always decorators, they just use
different syntax in native classes and classic classes.
Also updates
setComputedDecorator
andisComputedDecorator
tosetClassicDecorator
andisClassicDecorator
, since that is a bit more accurate for what they are being used for.