-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFC #435] Add feature flag and tests for forwarding modifiers with splattributes #17842
[RFC #435] Add feature flag and tests for forwarding modifiers with splattributes #17842
Conversation
3cb45e4
to
38c1322
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, @chancancode mind doing a review pass also?
38c1322
to
4c7b3a0
Compare
@rwjblue before merging I take that we should have a non-alpha release of glimmer containing that feature, right? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wasn’t able to look closely at the tests on my phone but the rest seems good to me 👍
}, | ||
enter(node: AST.ElementNode) { | ||
if (node.modifiers.length > 0 && isComponentInvocation(node)) { | ||
assert(`Modifiers cannot be applied to components. ${calculateLocationDisplay( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: since we are about to roll this out/tech this to people, let’s avoid the “cannot be applied” wording, and go for something like “Passing modifiers to components require the xyz canary feature, which has not been stabilized yet. See RFC xyz for details.”
FEATURES.md
Outdated
@@ -50,3 +50,10 @@ for a detailed explanation. | |||
with the angle bracket invocation sytnax. | |||
|
|||
See [RFC #459](https://github.com/emberjs/rfcs/pull/459). | |||
|
|||
* `ember-glimmer-pass-modifiers-with-splattributes` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: pass -> forward to match the RFC title
4c7b3a0
to
cc1f387
Compare
… with splattributes
cc1f387
to
6e253dc
Compare
@chancancode updated |
No description provided.